-
Notifications
You must be signed in to change notification settings - Fork 374
http-client-java, fix duplicate generated sample on advanced versioning #11014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weidongxu-microsoft
merged 6 commits into
microsoft:main
from
weidongxu-microsoft:http-client-java_fix-duplicate-generated-sample-on-advanced-versioning
Jun 18, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7c89040
skip duplicated method in samples
weidongxu-microsoft 0392acc
changelog
weidongxu-microsoft 993abae
chore(http-client-java): update Node.js dependencies
weidongxu-microsoft 08d60b0
Merge branch 'main' into http-client-java_fix-duplicate-generated-sam…
weidongxu-microsoft 49479ca
regen
weidongxu-microsoft c4265c5
Merge branch 'http-client-java_fix-duplicate-generated-sample-on-adva…
weidongxu-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
...ava_fix-duplicate-generated-sample-on-advanced-versioning-2026-5-18-11-39-58.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: fix | ||
| packages: | ||
| - "@typespec/http-client-java" | ||
| --- | ||
|
|
||
| Fix duplicate method in generated samples, when advanced-versioning=true |
7 changes: 7 additions & 0 deletions
7
...ava_fix-duplicate-generated-sample-on-advanced-versioning-2026-5-18-11-44-18.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: dependencies | ||
| packages: | ||
| - "@typespec/http-client-java" | ||
| --- | ||
|
|
||
| Update Node.js dependencies: @azure-tools/typespec-autorest 0.69.1, @azure-tools/typespec-azure-resource-manager 0.69.1, @azure-tools/typespec-azure-rulesets 0.69.1, @microsoft/api-extractor 7.58.9, @types/node 25.9.3, @vitest/coverage-v8 4.1.9, @vitest/ui 4.1.9, vitest 4.1.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
...es/java/tsptest/armversioned/generated/TopLevelArmResourcesGetByResourceGroupSamples.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| // Code generated by Microsoft (R) TypeSpec Code Generator. | ||
|
|
||
| package tsptest.armversioned.generated; | ||
|
|
||
| /** | ||
| * Samples for TopLevelArmResources GetByResourceGroup. | ||
| */ | ||
| public final class TopLevelArmResourcesGetByResourceGroupSamples { | ||
| /* | ||
| * x-ms-original-file: 2024-12-01/TopLevelArmResources_Get.json | ||
| */ | ||
| /** | ||
| * Sample code: TopLevelArmResources Get. | ||
| * | ||
| * @param manager Entry point to ArmVersionedManager. | ||
| */ | ||
| public static void topLevelArmResourcesGet(tsptest.armversioned.ArmVersionedManager manager) { | ||
| manager.topLevelArmResources() | ||
| .getByResourceGroupWithResponse("resource-group-name", "resource-name", "parameter-value", | ||
| "new-parameter-value", com.azure.core.util.Context.NONE); | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
...enerator/http-client-generator-test/tsp/examples/2024-12-01/TopLevelArmResources_Get.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "operationId": "TopLevelArmResources_Get", | ||
| "title": "TopLevelArmResources Get", | ||
| "parameters": { | ||
| "resourceGroupName": "resource-group-name", | ||
| "topLevelArmResourcePropertiesName": "resource-name", | ||
| "api-version": "2024-12-01", | ||
| "parameter": "parameter-value", | ||
| "newParameter": "new-parameter-value" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resource-group-name/providers/TspTest.ArmVersioned/topLevelArmResources/resource-name", | ||
| "name": "resource-name", | ||
| "type": "TspTest.ArmVersioned/topLevelArmResources", | ||
| "location": "eastus", | ||
| "properties": { | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.