fix(http-client-python): avoid shell-quote leak in package-pprint-name#11177
Merged
iscai-msft merged 3 commits intoJul 6, 2026
Merged
Conversation
Shell-escaping quotes for package-pprint-name were baked into the option value in addDefaultOptions. When venv creation fails and the emitter falls back to Pyodide, that already-quoted value is passed as a literal kwarg, producing an invalid setup.py (PACKAGE_PPRINT_NAME = ""..."") that black cannot parse. Quoting is now applied only when building the native Python shell command via quoteShellArg. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
requested review from
ChenxiJiang333,
catalinaperalta,
kashifkhan,
l0lawrence,
lmazuel,
msyyc,
tadelesh and
timotheeguerin
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
All changed packages have been documented.
Show changes
|
Address CodeQL 'Incomplete string escaping' by escaping backslash characters before double quotes, so a trailing or pre-quote backslash cannot break out of the quoted argument. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You can try these changes here
|
l0lawrence
reviewed
Jul 6, 2026
l0lawrence
approved these changes
Jul 6, 2026
tadelesh
pushed a commit
that referenced
this pull request
Jul 9, 2026
#11177) Shell-escaping quotes for package-pprint-name were baked into the option value in addDefaultOptions. When venv creation fails and the emitter falls back to Pyodide, that already-quoted value is passed as a literal kwarg, producing an invalid setup.py (PACKAGE_PPRINT_NAME = ""..."") that black cannot parse. Quoting is now applied only when building the native Python shell command via quoteShellArg. --------- Co-authored-by: iscai-msft <isabellavcai@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell-escaping quotes for package-pprint-name were baked into the option value in addDefaultOptions. When venv creation fails and the emitter falls back to Pyodide, that already-quoted value is passed as a literal kwarg, producing an invalid setup.py (PACKAGE_PPRINT_NAME = ""..."") that black cannot parse. Quoting is now applied only when building the native Python shell command via quoteShellArg.