[Python] generate metadata files #7359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:python
|
All changed packages have been documented.
|
|
You can try these changes here
|
msyyc
requested review from
iscai-msft,
tadelesh,
timotheeguerin and
lmazuel
as code owners
msyyc
changed the title
lirenhe
reviewed
May 16, 2025
| @@ -323,5 +323,8 @@ export function emitCodeModel(sdkContext: PythonSdkContext) { | |||
| ...simpleTypesMap.values(), | |||
| ]; | |||
| codeModel["crossLanguagePackageId"] = ignoreDiagnostics(getCrossLanguagePackageId(sdkContext)); | |||
| if ((sdkContext.emitContext.options as any).flavor === "azure") { | |||
There was a problem hiding this comment.
Any test cases that we could verify this change?
There was a problem hiding this comment.
_metadata.json is not part of package so we can't test it by import then check like other cases. You can see the generated file in PR https://github.com/Azure/autorest.python/pull/3089/files#diff-3cd63a63f5c9e91001bdea81bb22b04fb20951ffae50393999131961cd61af6b
There was a problem hiding this comment.
i see. So for python, we only include the value of api-version?
iscai-msft
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7057