[typespec-vscode] emitter's options as comment when updating tspconfig file #7691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h user selected emitter in CodeGeneration scenario
mzhongl524
requested review from
RodgeFu,
lirenhe,
bterlson,
markcowl,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
|
All changed packages have been documented.
|
|
You can try these changes here
|
RodgeFu
reviewed
Jun 30, 2025
RodgeFu
reviewed
Jun 30, 2025
RodgeFu
reviewed
Jun 30, 2025
RodgeFu
reviewed
Jun 30, 2025
RodgeFu
reviewed
Jun 30, 2025
RodgeFu
reviewed
Jul 3, 2025
RodgeFu
reviewed
Jul 3, 2025
RodgeFu
reviewed
Jul 3, 2025
RodgeFu
reviewed
Jul 3, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 18, 2025
RodgeFu
reviewed
Jul 21, 2025
RodgeFu
reviewed
Jul 21, 2025
There was a problem hiding this comment.
Can you share a gif of what this looks like? Does it keep adding the options even if we delete them?
Do we really feel like this is valuable now that we have auto complete in the config? This just feels like noise to me. Only time I would see this being valuable is in the init flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5621
Include emitter's options as comment when updating
tspconfig.yamlwith user selected emitter inCodeGenerationscenario