Add HttpRequestClientIdPropertyName to HttpRequestApi #7827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
No changes needing a change description found. |
jorgerangel-msft
changed the title
jorgerangel-msft
requested review from
m-nash,
JoshLove-msft,
christothes and
jsquire
as code owners
jorgerangel-msft
commented
Jul 3, 2025
.../generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/PipelineRequestProvider.cs
Outdated
Show resolved
Hide resolved
...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/Abstractions/HttpRequestApi.cs
Outdated
Show resolved
Hide resolved
| @@ -24,5 +24,6 @@ protected HttpRequestApi(CSharpType type, ValueExpression original) : base(type, | |||
| public abstract ValueExpression Content(); | |||
| public abstract HttpRequestApi FromExpression(ValueExpression original); | |||
| public abstract HttpRequestApi ToExpression(); | |||
| public abstract string? ClientRequestIdPropertyName { get; } | |||
There was a problem hiding this comment.
why we must put a XXXName here?
These abstractions should be returning the expressions such as
public abstract ScopedApi<string>? ClientRequestId();
like we have above for Content - we did not have a HttpRequestContentPropertyName, instead we made a thing to return the corresponding expression.
|
We will use a separate visitor instead of adding an additional API. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the HttpRequestApi to include a new API for setting the RequestClientId property name for http request types.
contributes to Azure/azure-sdk-for-net#50627