Skip to content

[python] Fix constant query #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 24, 2025
Merged

[python] Fix constant query #8806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a473ef3
fix constant query
msyyc Oct 23, 2025
d4595de
add changelog
msyyc Oct 23, 2025
f510f59
update
msyyc Oct 23, 2025
9c14b85
fix for api version
msyyc Oct 24, 2025
96d9026
update test case
msyyc Oct 24, 2025
03c5d89
Delete .chronus/changes/HEAD-2025-9-23-16-46-9.md
msyyc Oct 24, 2025
cba7ae3
add changelog
msyyc Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-python-constant-query-2025-9-24-14-46-59.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-python"
---

Fix runtime error for constant query parameter
4 changes: 3 additions & 1 deletion packages/http-client-python/generator/pygen/codegen/serializers/parameter_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,11 @@ def append_pop_kwarg(key: str, pop_type: PopKwargType) -> None:
if is_content_type_optional and not type_annotation.startswith("Optional[")
else type_annotation
)
if kwarg.client_default_value is not None or kwarg.optional:
if kwarg.client_default_value is not None or kwarg.optional or kwarg.constant:
if check_client_input and kwarg.check_client_input:
default_value = f"self._config.{kwarg.client_name}"
elif kwarg.constant:
default_value = kwarg.type.get_declaration(None)
else:
default_value = kwarg.client_default_value_declaration
if check_kwarg_dict and (kwarg.location in [ParameterLocation.HEADER, ParameterLocation.QUERY]):
Expand Down
5 changes: 5 additions & 0 deletions packages/http-client-python/generator/test/generic_mock_api_tests/test_typetest_scalar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,8 @@ def test_decimal128_verify(client: ScalarClient):
def test_decimal_verify(client: ScalarClient):
prepare = client.decimal_verify.prepare_verify()
client.decimal_verify.verify(reduce(lambda x, y: x + y, prepare))


# open this test case after adopt new version of http-specs for https://github.com/microsoft/typespec/pull/8807
# def test_constant_query(client: ScalarClient):
# client.constant_query.post()
Loading