-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Revert "first cut - migrate settings marked with INTERNAL and adopt to advanced tag" #2021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -34,11 +34,11 @@ import { StringText } from '../../../../util/vs/editor/common/core/text/abstract | |||||||||||||||||||||
| import { getInformationDelta, InformationDelta } from '../../common/informationDelta'; | ||||||||||||||||||||||
| import { RejectionCollector } from '../../common/rejectionCollector'; | ||||||||||||||||||||||
| import { IVSCodeObservableDocument, VSCodeWorkspace } from '../parts/vscodeWorkspace'; | ||||||||||||||||||||||
| import { toInternalPosition } from '../utils/translations'; | ||||||||||||||||||||||
| import { AnyDiagnosticCompletionItem, AnyDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/anyDiagnosticsCompletionProvider'; | ||||||||||||||||||||||
| import { AsyncDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/asyncDiagnosticsCompletionProvider'; | ||||||||||||||||||||||
| import { Diagnostic, DiagnosticCompletionItem, DiagnosticInlineEditRequestLogContext, distanceToClosestDiagnostic, IDiagnosticCompletionProvider, log, logList, sortDiagnosticsByDistance } from './diagnosticsBasedCompletions/diagnosticsCompletions'; | ||||||||||||||||||||||
| import { ImportDiagnosticCompletionItem, ImportDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/importDiagnosticsCompletionProvider'; | ||||||||||||||||||||||
| import { toInternalPosition } from '../utils/translations'; | ||||||||||||||||||||||
|
Comment on lines
37
to
+41
|
||||||||||||||||||||||
| import { AnyDiagnosticCompletionItem, AnyDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/anyDiagnosticsCompletionProvider'; | |
| import { AsyncDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/asyncDiagnosticsCompletionProvider'; | |
| import { Diagnostic, DiagnosticCompletionItem, DiagnosticInlineEditRequestLogContext, distanceToClosestDiagnostic, IDiagnosticCompletionProvider, log, logList, sortDiagnosticsByDistance } from './diagnosticsBasedCompletions/diagnosticsCompletions'; | |
| import { ImportDiagnosticCompletionItem, ImportDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/importDiagnosticsCompletionProvider'; | |
| import { toInternalPosition } from '../utils/translations'; | |
| import { toInternalPosition } from '../utils/translations'; | |
| import { AnyDiagnosticCompletionItem, AnyDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/anyDiagnosticsCompletionProvider'; | |
| import { AsyncDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/asyncDiagnosticsCompletionProvider'; | |
| import { Diagnostic, DiagnosticCompletionItem, DiagnosticInlineEditRequestLogContext, distanceToClosestDiagnostic, IDiagnosticCompletionProvider, log, logList, sortDiagnosticsByDistance } from './diagnosticsBasedCompletions/diagnosticsCompletions'; | |
| import { ImportDiagnosticCompletionItem, ImportDiagnosticCompletionProvider } from './diagnosticsBasedCompletions/importDiagnosticsCompletionProvider'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event firing logic is missing in the
registerConfigurationMigrationsmethod. The original implementation (being removed from configurationService.ts) includedthis._onDidRegisterConfigurationMigrations.fire(configurationMigrations);after pushing migrations, but the new implementation in this file omits this line. This could cause listeners to not be notified when configuration migrations are registered.