[typescript-language-features] Use commit characters from tsserver when available - #223541
Merged
Merged
Conversation
Matt Bierner (mjbvz)
approved these changes
Jul 26, 2024
Matt Bierner (mjbvz)
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Should be good to merge soon to get some testing on VS Code insiders
| // @ts-expect-error until TS 5.6 | ||
| let commitCharacters = entry.commitCharacters ?? defaultCommitCharacters; | ||
| if (commitCharacters) { | ||
| if (context.enableCallCompletions |
Contributor
There was a problem hiding this comment.
Should this logic be moved to the TS side?
Member
Author
There was a problem hiding this comment.
In the future, yes. I didn't include that on TS Server for now because I'm still working out what our approach for commit characters will be exactly. It could be that this setting becomes irrelevant and we start offering ( as a commit character on TSServer by default, or we could want more settings. But one way or the other, we'll eventually get rid of this logic on the vscode side.
Contributor
There was a problem hiding this comment.
Ok that sounds good. I'll go ahead and merge this initial version then
roblourens
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with TS 5.6, TSServer will now send commit characters for completions:
microsoft/TypeScript#59339