Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open files as preview from the command line (--preview) #48347

Closed
wants to merge 1 commit into from

Conversation

gzzhanghao
Copy link

It makes it easier to implement devtools in this video. (from vuejs/vue#8034)

@msftclas
Copy link

msftclas commented Apr 22, 2018

CLA assistant check
All CLA requirements met.

@bpasero
Copy link
Member

bpasero commented Apr 23, 2018

@gzzhanghao out of curiosity, that IDE in the development tools looks a bit like VS Code, what is it? And how would this change have any impact on that IDE of the video?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 23, 2018
@gzzhanghao
Copy link
Author

@bpasero that video is from @NeekSandhu, I'm not sure what it is.

I'm just trying to implement something like that but with vscode as the main editor. It could be done with a WebSocket server that opens local editor with command line. That's why I need the preview option here.

@bpasero bpasero removed the info-needed Issue requires more information from poster label Apr 23, 2018
@bpasero bpasero added this to the Backlog milestone Apr 23, 2018
@bpasero bpasero changed the title Add --preview option for cli Allow to open files as preview from the command line (--preview) Apr 23, 2018
@zikaari
Copy link

zikaari commented Apr 23, 2018

I'm glad to see it featured/referred here. It's a Chrome DevTools extension I am working on. In a nutshell, it's basically a cross between vscode and devtools' workspace, bringing best of both worlds in one place.

While I have you guys here, let me know what you guys think of it (thoughts on usefulness, general feedback, etc.)

PS: I'm also looking for collaborators/contributors if you or anyone you know shares the same vision. Please hit me up.

@gzzhanghao
Copy link
Author

I found that we can open vscode with URLs. So I wonder if we can extend the URL query to pass external options to it. eg: vscode://file/c:/myProject/package.json:5:10?preview&preserveFocus. We can implement the devtool without a local server if that's possible.

@bpasero
Copy link
Member

bpasero commented Aug 15, 2018

I find it hard to argue to have this option, closing.

@bpasero bpasero closed this Aug 15, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants