Remove CPM, add CMakePresets.json and OR-Tools + HTSlib installation script #102
Merged
Remove CPM, add CMakePresets.json and OR-Tools + HTSlib installation script #102
Conversation
mytkom
reviewed
Aug 6, 2025
Collaborator
|
Tested on NixOS: works well. I fixed try catch logic for get_subcommand() (and tested that it works both for app and tests). I also need to refactor the NixOS flake, because the current one is like hell---maybe new versions of packages fix things, but it is a long process, so I will do it in a separate PR. Btw. I love those presets <3!!! |
mytkom
approved these changes
Aug 6, 2025
Collaborator
mytkom
left a comment
mytkom
left a comment
There was a problem hiding this comment.
compile_commands.json now works well with my NVIM. Nice work.
Willu12
approved these changes
Aug 7, 2025
Collaborator
Willu12
left a comment
Willu12
left a comment
There was a problem hiding this comment.
Tested on ubuntu 24.04 - works great!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also simplified CMake, Dockerfile and gh workflow. Added GoogleTest fetcher function if we decide to use it in the future.
What should be tested:
cmake --preset gcc-x64-(release|debug) && cmake --build --preset gcc-x64-(release|debug)work on your platform?./scripts/install_libs install --prefix /tmp/testnot fail? Already tested on ubuntu 22:04 and on arch linux btw.