make GetReposContentsByOwnerByRepoByPath path optional #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szesch Thanks for the contribution! Something that will play a role here is that the endpointspattern.go file is actually auto generated so we can't directly modify it. There are a few other endpoints like this where the default regular expression is not quite correct. To modify it, you can look here for an example. You'll see that it intercepts the generation and allows us to define a different expression like you did. After creating a new expression you can then run the Give it a go and I'm happy to review your change and get it merged. |
trumant
added a commit
to trumant/go-github-mock
that referenced
this pull request
Apr 21, 2025
This PR also updates from v69-v71 as a side effect of re-running mock generation. This change extends the work done by @szesch based on the PR commentary in migueleliasweb#81
trumant
added a commit
to trumant/go-github-mock
that referenced
this pull request
May 1, 2025
This PR also updates from v69-v71 as a side effect of re-running mock generation. This change extends the work done by @szesch based on the PR commentary in migueleliasweb#81
|
Need to re-test my use case but will do so in the next 48 hours and let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github docs for getting repository content state
The docs are incorrect and mark the path as required. This PR makes the path optional.