Dropbox same attachment filename issue fixed #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, automatically correct filename is passed to _getShareUrl function. As a result proper URL is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message - "Uploaded file name returned by Dropbox process is assigned to leafName, automatically correct filename is passed to _getShareUrl function. As a result proper URL is returned."
If in your opinion assigning to this variable is a mistake (or just bad practice) just let me know and I will replace it with another code, where special variable is created for this purpose.
There is still wrong file name inserted into mail body, but it seems to be more problematic to fix.
Tested on Xubuntu 12.04.1 and Thunderbird 16.0.2