Refactor cleanup tests #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rking788
reviewed
Feb 5, 2018
| @@ -36,10 +36,9 @@ func main() { | |||
| http.ListenAndServe(":8080", nil) | |||
| } | |||
|
|
|||
| func onLaunch(launchRequest *request.LaunchRequest) (*response.Response, map[string]interface{}, error) { | |||
| func onLaunch(launchRequest *request.LaunchRequest, metadata *request.Metadata) (*response.Response, map[string]interface{}, error) { | |||
| resp := response.New() | |||
| resp.SetEndSession(response.Bool(true)) | |||
There was a problem hiding this comment.
Should the session stay open if the user is launching the skill? seems like the example could be misleading.
There was a problem hiding this comment.
Would it be worth adding some speech here so if the user tries it out then they can at least get some output speech?
There was a problem hiding this comment.
Seems reasonably. It's on my "todo" list but I'm currently getting slammed at work. Hope to have time later this week to work on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This code change assumes the
Add metadata to customskill handlerscommit is going to be pulled in from #36. Sorry for the noise from that commit.A few little changes here:
Errorfyou can just uset.Run(name, ...). I've applied this to all tests.deferso that has been added to all tests that use mocked functions.got/wantedovergot/expected(or similar). Mostly just for standardization.