Skip to content

Fix compatibility with polymode after pm--visible-buffer-name removal #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix compatibility with polymode after pm--visible-buffer-name removal #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd155d9
Fix compatibility with polymode after pm--visible-buffer-name removal
natsirtguy Jun 18, 2025
0aa09c5
Fix deprecated GitHub Actions versions
natsirtguy Jun 18, 2025
8396489
Update Python version from 3.7 to 3.8 in CI workflow
natsirtguy Jun 18, 2025
2ff01b4
Remove Emacs 26.3 from CI test matrix
natsirtguy Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
emacs_version: [26.3, 27.2, 28.2, 29.1]
python-version: [3.7]
emacs_version: [27.2, 28.2, 29.1]
python-version: [3.8]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -34,13 +34,13 @@ jobs:
with:
version: ${{ matrix.emacs_version }}

- uses: actions/cache@v2
- uses: actions/cache@v4
id: cache-cask-packages
with:
path: .cask
key: cache-cask-packages-001

- uses: actions/cache@v2
- uses: actions/cache@v4
id: cache-cask-executable
with:
path: ~/.cask
Expand Down
6 changes: 3 additions & 3 deletions lisp/poly-ein.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,13 @@ TYPE can be \\='body, nil."
(apply-partially #'poly-ein--narrow-to-inner #'identity))))

(defun poly-ein--record-window-buffer ()
"(pm--visible-buffer-name) needs to get onto window's prev-buffers.
"(pm--buffer-name) needs to get onto window's prev-buffers.
But `C-x b` seems to consult `buffer-list' and not the C (window)->prev_buffers."
(when (buffer-base-buffer)
(let* ((buffer-list (frame-parameter nil 'buffer-list))
(pos-visible (seq-position
buffer-list
(pm--visible-buffer-name)
(pm--buffer-name)
(lambda (x visible*)
(string-prefix-p (buffer-name x) visible*)))))
;; no way to know if i've switched in or out of indirect buf.
Expand All @@ -382,7 +382,7 @@ But `C-x b` seems to consult `buffer-list' and not the C (window)->prev_buffers.
(add-hook 'ido-make-buffer-list-hook
(lambda ()
(defvar ido-temp-list)
(when-let ((visible (pm--visible-buffer-name)))
(when-let ((visible (pm--buffer-name)))
(ido-to-end (delq nil
(mapcar (lambda (x)
(when (string-prefix-p x visible) x))
Expand Down