-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add database param to manual compact api #367
Conversation
Signed-off-by: Wei Liu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
/lgtm |
Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
@@ -1216,6 +1216,7 @@ message ManualCompactionRequest { | |||
uint64 timetravel = 2; | |||
bool majorCompaction = 3; | |||
string collection_name = 4; | |||
string db_name = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh
issue: milvus-io/milvus#38086