improve: unindexed collection can be compacted

Signed-off-by: xiaofanluan <[email protected]>
milvus-io · Feb 5, 2025 · 76d8a78 · 76d8a78
1 parent b3791a6
commit 76d8a78
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/internal/datacoord/compaction_policy_single.go b/internal/datacoord/compaction_policy_single.go
@@ -99,7 +99,7 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
 	views := make([]CompactionView, 0)
 	for _, group := range partSegments {
 		if Params.DataCoordCfg.IndexBasedCompaction.GetAsBool() {
-			group.segments = FilterInIndexedSegments(policy.handler, policy.meta, false, group.segments...)
+			group.segments = FilterInIndexedSegments(policy.handler, policy.meta, true, group.segments...)
 		}
 
 		collectionTTL, err := getCollectionTTL(collection.Properties)

diff --git a/internal/datacoord/compaction_trigger.go b/internal/datacoord/compaction_trigger.go
@@ -327,7 +327,7 @@ func (t *compactionTrigger) handleGlobalSignal(signal *compactionSignal) error {
 		}
 
 		if Params.DataCoordCfg.IndexBasedCompaction.GetAsBool() {
-			group.segments = FilterInIndexedSegments(t.handler, t.meta, signal.isForce, group.segments...)
+			group.segments = FilterInIndexedSegments(t.handler, t.meta, true, group.segments...)
 		}
 
 		coll, err := t.getCollection(group.collectionID)
@@ -625,7 +625,7 @@ func (t *compactionTrigger) generatePlans(segments []*SegmentInfo, signal *compa
 func (t *compactionTrigger) getCandidateSegments(channel string, partitionID UniqueID) []*SegmentInfo {
 	segments := t.meta.GetSegmentsByChannel(channel)
 	if Params.DataCoordCfg.IndexBasedCompaction.GetAsBool() {
-		segments = FilterInIndexedSegments(t.handler, t.meta, false, segments...)
+		segments = FilterInIndexedSegments(t.handler, t.meta, true, segments...)
 	}
 
 	var res []*SegmentInfo

diff --git a/internal/datacoord/garbage_collector.go b/internal/datacoord/garbage_collector.go
@@ -440,7 +440,7 @@ func (gc *garbageCollector) recycleDroppedSegments(ctx context.Context) {
 			droppedCompactTo[to] = struct{}{}
 		}
 	}
-	indexedSegments := FilterInIndexedSegments(gc.handler, gc.meta, false, lo.Keys(droppedCompactTo)...)
+	indexedSegments := FilterInIndexedSegments(gc.handler, gc.meta, true, lo.Keys(droppedCompactTo)...)
 	indexedSet := make(typeutil.UniqueSet)
 	for _, segment := range indexedSegments {
 		indexedSet.Insert(segment.GetID())