enhance: enable rmq for streaming #38669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mergify
bot
added
dco-passed
chyezh
force-pushed
the
enhance_enable_rmq_for_streaming
branch
from
4e221c7 to
5d9d1d3
Compare
Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
enhance_enable_rmq_for_streaming
branch
2 times, most recently
from
bfeed25 to
a63e5b0
Compare
|
@chyezh go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38669 +/- ##
===========================================
+ Coverage 69.33% 81.08% +11.74%
===========================================
Files 292 1381 +1089
Lines 26187 195200 +169013
===========================================
+ Hits 18158 158272 +140114
- Misses 8029 31342 +23313
- Partials 0 5586 +5586
|
Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
enhance_enable_rmq_for_streaming
branch
from
a63e5b0 to
803fa3e
Compare
jaime0815
reviewed
Dec 24, 2024
| @@ -191,6 +198,17 @@ func (c *client) tryToConsume(consumer *consumer) []*RmqMessage { | |||
| } | |||
| rmqMsgs := make([]*RmqMessage, 0, len(msgs)) | |||
| for _, msg := range msgs { | |||
| rmqMsg, err := unmarshalStreamingMessage(consumer.topic, msg) | |||
| if err == nil { | |||
There was a problem hiding this comment.
The error code makes it difficult to determine whether the message is from the streaming node; checking the message source directly is clearer.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
NicoYuan1986
pushed a commit
to NicoYuan1986/milvus
that referenced
this pull request
Dec 26, 2024
issue: milvus-io#38399 --------- Signed-off-by: chyezh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #38399