Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the close operation of rmq consumer is not sync #38734

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 25, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (4df444e) to head (4a4cd7a).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38734      +/-   ##
==========================================
+ Coverage   81.09%   81.13%   +0.04%     
==========================================
  Files        1383     1385       +2     
  Lines      195636   195831     +195     
==========================================
+ Hits       158642   158894     +252     
+ Misses      31404    31359      -45     
+ Partials     5590     5578      -12     
Components Coverage Δ
Client 78.73% <ø> (+0.47%) ⬆️
Core 69.47% <ø> (+0.03%) ⬆️
Go 83.11% <100.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
pkg/mq/mqimpl/rocksmq/client/client_impl.go 82.69% <100.00%> (+0.22%) ⬆️
pkg/mq/mqimpl/rocksmq/client/consumer_impl.go 96.59% <100.00%> (+0.29%) ⬆️

... and 36 files with indirect coverage changes

@chyezh chyezh force-pushed the fix_rmq_data_race branch 2 times, most recently from d404aef to e08434f Compare December 25, 2024 08:57
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 26, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Dec 27, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: chyezh <[email protected]>
@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun cpp-unit-test

2 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Dec 27, 2024

rerun cpp-unit-test

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Dec 28, 2024

rerun cpp-unit-test

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 56c5b66 into milvus-io:master Dec 30, 2024
20 checks passed
@chyezh chyezh deleted the fix_rmq_data_race branch December 30, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants