-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: move streaming coord from datacoord to rootcoord #39007
enhance: move streaming coord from datacoord to rootcoord #39007
Conversation
4c8b4fe
to
06f9c9f
Compare
@chyezh go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39007 +/- ##
===========================================
+ Coverage 69.52% 81.14% +11.62%
===========================================
Files 296 1389 +1093
Lines 26553 196503 +169950
===========================================
+ Hits 18462 159461 +140999
- Misses 8091 31451 +23360
- Partials 0 5591 +5591
|
06f9c9f
to
a63f8a7
Compare
@chyezh go-sdk check failed, comment |
@chyezh E2e jenkins job failed, comment |
Signed-off-by: chyezh <[email protected]>
410ccce
to
bc5f16a
Compare
Signed-off-by: chyezh <[email protected]>
bc5f16a
to
d7e6f98
Compare
@chyezh go-sdk check failed, comment |
rerun go-sdk |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #38399 pr: #39007 We want to support broadcast operation for both streaming and msgstream. But msgstream can be only sent message from rootcoord and proxy. So this pr move the streamingcoord to rootcoord to make easier implementation. --------- Signed-off-by: chyezh <[email protected]>
issue: #38399
We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier implementation.