Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make pkg available with proto #39067

Closed

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 8, 2025

issue: #38399

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (134952b) to head (0075119).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39067       +/-   ##
===========================================
- Coverage   82.97%   69.53%   -13.44%     
===========================================
  Files        1093      296      -797     
  Lines      169983    26606   -143377     
===========================================
- Hits       141041    18501   -122540     
+ Misses      23357     8105    -15252     
+ Partials     5585        0     -5585     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.53% <ø> (∅)
Go ∅ <ø> (∅)

see 1389 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Jan 8, 2025

block by ci

@chyezh chyezh closed this Jan 8, 2025
@chyezh chyezh deleted the enhance_make_pkg_avaialble_with_proto branch January 8, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants