Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make pkg available with proto #39068

Closed

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 8, 2025

issue: #38399

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 8, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chyezh chyezh force-pushed the enhance_make_pkg_avaialble_with_proto_2_5 branch from 492229f to a3e8120 Compare January 8, 2025 03:50
@mergify mergify bot added the dco-passed DCO check passed. label Jan 8, 2025
Copy link
Contributor

mergify bot commented Jan 8, 2025

@chyezh Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
Copy link
Contributor

mergify bot commented Jan 8, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (4b62dfd) to head (a3e8120).
Report is 1 commits behind head on 2.5.

❗ There is a different number of reports uploaded between BASE (4b62dfd) and HEAD (a3e8120). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4b62dfd) HEAD (a3e8120)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39068       +/-   ##
===========================================
- Coverage   81.06%   69.45%   -11.62%     
===========================================
  Files        1384      294     -1090     
  Lines      195588    26429   -169159     
===========================================
- Hits       158549    18355   -140194     
+ Misses      31464     8074    -23390     
+ Partials     5575        0     -5575     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.45% <ø> (+0.01%) ⬆️
Go ∅ <ø> (∅)

see 1091 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Jan 8, 2025

block by ci

@chyezh chyezh closed this Jan 8, 2025
@chyezh chyezh deleted the enhance_make_pkg_avaialble_with_proto_2_5 branch January 8, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants