Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Add schema update time verification for insert and upsert to use cache #39405

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Jan 17, 2025

enhance: Add schema update time verification for insert and upsert to use cache
issue: #39093
Related to pr: #39096

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file labels Jan 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

… the cache

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

fix code

Signed-off-by: Xianhui.Lin <[email protected]>

fix test

Signed-off-by: Xianhui.Lin <[email protected]>

fix go test

Signed-off-by: Xianhui.Lin <[email protected]>

add go unitest

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest error

Signed-off-by: Xianhui.Lin <[email protected]>

fix ut

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

createcollection use creats

Signed-off-by: Xianhui.Lin <[email protected]>

save to etcd

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>
@JsDove
Copy link
Contributor Author

JsDove commented Jan 18, 2025

rerun ut

@mergify mergify bot added the ci-passed label Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 47.76119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (b6be11c) to head (0d55a55).
Report is 9 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/task_insert.go 12.50% 11 Missing and 3 partials ⚠️
internal/proxy/task_upsert.go 12.50% 11 Missing and 3 partials ⚠️
internal/rootcoord/alter_collection_task.go 50.00% 5 Missing ⚠️
pkg/util/merr/utils.go 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39405      +/-   ##
==========================================
- Coverage   80.41%   80.41%   -0.01%     
==========================================
  Files        1080     1080              
  Lines      169974   170033      +59     
==========================================
+ Hits       136687   136733      +46     
- Misses      28784    28791       +7     
- Partials     4503     4509       +6     
Files with missing lines Coverage Δ
internal/metastore/model/collection.go 81.10% <100.00%> (+0.45%) ⬆️
internal/proxy/impl.go 83.87% <100.00%> (+<0.01%) ⬆️
internal/proxy/meta_cache.go 88.08% <100.00%> (+0.01%) ⬆️
internal/proxy/task.go 81.60% <100.00%> (+0.01%) ⬆️
internal/rootcoord/create_collection_task.go 94.43% <100.00%> (+0.01%) ⬆️
internal/rootcoord/root_coord.go 87.78% <100.00%> (+<0.01%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 83.09% <75.00%> (-0.08%) ⬇️
internal/rootcoord/alter_collection_task.go 50.78% <50.00%> (-0.05%) ⬇️
internal/proxy/task_insert.go 69.43% <12.50%> (-4.28%) ⬇️
... and 1 more

... and 31 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 21, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6111a0d into milvus-io:2.4 Jan 21, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants