Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update milvusproto version to 2.5.5 #39478

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Jan 21, 2025

feat: update milvusproto version to 2.5
issue: #39093

Signed-off-by: Xianhui.Lin <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 21, 2025
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing labels Jan 21, 2025
Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the dco-passed DCO check passed. label Jan 21, 2025
@JsDove JsDove changed the title feat: update milvusproto version to 2.5 feat: update milvusproto version to 2.5.5 Jan 21, 2025
@mergify mergify bot added do-not-merge/missing-related-pr kind/feature Issues related to feature request from users labels Jan 21, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 21, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

/run-cpu-e2e

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun cpp-unit-test

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

/run-cpu-e2e

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 21, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 21, 2025

rerun go-sdk

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (f912cbf) to head (c584b2d).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39478      +/-   ##
==========================================
- Coverage   81.00%   80.98%   -0.03%     
==========================================
  Files        1404     1404              
  Lines      197861   197861              
==========================================
- Hits       160277   160230      -47     
- Misses      31963    31995      +32     
- Partials     5621     5636      +15     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.94% <ø> (-0.03%) ⬇️

see 33 files with indirect coverage changes

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 21, 2025
@sre-ci-robot sre-ci-robot merged commit 20c6de1 into milvus-io:2.5 Jan 21, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/branch-feature kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants