Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add configs for compaction schedule (#39010) #39511

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

pr: #39010

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 22, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (22a69b5) to head (e3e878a).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
pkg/util/paramtable/component_param.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39511      +/-   ##
==========================================
+ Coverage   80.99%   82.79%   +1.79%     
==========================================
  Files        1404     1104     -300     
  Lines      198042   171263   -26779     
==========================================
- Hits       160409   141798   -18611     
+ Misses      32002    23831    -8171     
- Partials     5631     5634       +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.96% <81.25%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 70.74% <100.00%> (+0.04%) ⬆️
pkg/util/paramtable/component_param.go 98.33% <76.92%> (-0.07%) ⬇️

... and 334 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 5, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants