-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support random sample #39532
base: master
Are you sure you want to change the base?
feat: support random sample #39532
Conversation
Signed-off-by: SpadeA-Tang <[email protected]>
…for expr in proxy module, 2. polish code and make enure the correctness, 3. add tests Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SpadeA-Tang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (77.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #39532 +/- ##
===========================================
- Coverage 81.00% 69.61% -11.40%
===========================================
Files 1407 302 -1105
Lines 198705 27103 -171602
===========================================
- Hits 160970 18868 -142102
+ Misses 32074 8235 -23839
+ Partials 5661 0 -5661
|
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang E2e jenkins job failed, comment |
@SpadeA-Tang cpp-unit-test check failed, comment |
@SpadeA-Tang go-sdk check failed, comment |
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
rerun go-sdk |
/run-cpu-e2e |
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun go-sdk |
@SpadeA-Tang E2e jenkins job failed, comment |
/run-cpu-e2e |
@SpadeA-Tang E2e jenkins job failed, comment |
/run-cpu-e2e |
issue: #39541
This PR implements random sample, the syntax is:
Some simple benchmarks with not using sample:
test environment:
ubuntu22, standalone cluster, CPU 9900K, 10_000_000 rows with schema:
number filed distributes within [0, 10) evenly.
content has 1/3 hit rate for the query for each row.