Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine variable-length-type memory usage(#38736) #39578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

enhance: refine variable-length-type memory usage(#38736)

296b1e6
Select commit
Loading
Failed to load commit list.
Open

enhance: refine variable-length-type memory usage(#38736) #39578

enhance: refine variable-length-type memory usage(#38736)
296b1e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 11, 2025 in 1s

80.16% (target 77.00%)

View this Pull Request on Codecov

80.16% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 78.57143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (74890da) to head (296b1e6).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/mmap/ChunkedColumn.h 22.22% 7 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.22% 7 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 12.50% 7 Missing ⚠️
internal/core/src/mmap/Column.h 20.00% 4 Missing ⚠️
internal/core/src/segcore/SegmentInterface.h 73.33% 4 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.cpp 0.00% 3 Missing ⚠️
internal/core/src/common/ChunkWriter.h 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39578      +/-   ##
==========================================
+ Coverage   80.07%   80.16%   +0.08%     
==========================================
  Files        1465     1480      +15     
  Lines      203449   204890    +1441     
==========================================
+ Hits       162918   164242    +1324     
- Misses      34709    34790      +81     
- Partials     5822     5858      +36     
Components Coverage Δ
Client 79.44% <ø> (-0.02%) ⬇️
Core 69.47% <78.57%> (+0.07%) ⬆️
Go 81.88% <ø> (+0.07%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Chunk.cpp 63.33% <100.00%> (-6.94%) ⬇️
internal/core/src/common/Chunk.h 89.74% <100.00%> (+5.21%) ⬆️
internal/core/src/common/ChunkTarget.h 100.00% <ø> (ø)
internal/core/src/common/ChunkWriter.cpp 70.64% <100.00%> (+14.27%) ⬆️
internal/core/src/common/Common.h 0.00% <ø> (-100.00%) ⬇️
internal/core/src/exec/expression/Expr.h 69.28% <ø> (ø)
internal/core/src/exec/expression/TermExpr.cpp 85.04% <ø> (ø)
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 28.57% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 69.04% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 57.14% <ø> (ø)
... and 8 more

... and 120 files with indirect coverage changes