Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cohere text embedding #39581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junjiejiangjjj
Copy link
Contributor

@junjiejiangjjj junjiejiangjjj commented Jan 24, 2025

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junjiejiangjjj
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 24, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 87.41722% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (47d280d) to head (05df333).
Report is 19 commits behind head on master.

Current head 05df333 differs from pull request most recent head 4e551b7

Please upload reports for the commit 4e551b7 to get more accurate results.

Files with missing lines Patch % Lines
...nternal/util/function/cohere_embedding_provider.go 89.41% 6 Missing and 3 partials ⚠️
...il/function/models/cohere/cohere_text_embedding.go 81.63% 6 Missing and 3 partials ⚠️
internal/util/function/text_embedding_function.go 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39581      +/-   ##
==========================================
- Coverage   80.92%   80.13%   -0.80%     
==========================================
  Files        1408     1466      +58     
  Lines      198890   203414    +4524     
==========================================
+ Hits       160950   163003    +2053     
- Misses      32229    34607    +2378     
- Partials     5711     5804      +93     
Components Coverage Δ
Client 79.45% <ø> (-0.06%) ⬇️
Core 69.39% <ø> (-0.18%) ⬇️
Go 81.87% <84.09%> (-0.97%) ⬇️
Files with missing lines Coverage Δ
internal/util/function/common.go 100.00% <ø> (ø)
internal/util/function/text_embedding_function.go 92.96% <94.11%> (ø)
...nternal/util/function/cohere_embedding_provider.go 89.41% <89.41%> (ø)
...il/function/models/cohere/cohere_text_embedding.go 81.63% <81.63%> (ø)

... and 180 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 6, 2025

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

@junjiejiangjjj
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: junjie.jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/feature Issues related to feature request from users size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants