fix: segment stats may be inconsistent after wal closing

[chyezh]

issue: #38399

• The stats may be kept after wal closing if the growing segment is not dirty.
• Change the error handling of wal open to avoid redundant manager api call.

[codecov]

Codecov Report

Attention: Patch coverage is 79.12088% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (e61a841) to head (6553911).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...l/interceptors/segment/manager/pchannel_manager.go	56.25%	7 Missing ⚠️
...server/wal/interceptors/segment/inspector/impls.go	50.00%	4 Missing ⚠️
...al/streamingnode/server/walmanager/wal_lifetime.go	62.50%	2 Missing and 1 partial ⚠️
...er/wal/interceptors/segment/stats/stats_manager.go	93.75%	1 Missing and 1 partial ⚠️
...al/streamingnode/server/walmanager/manager_impl.go	33.33%	2 Missing ⚠️
...al/streamingcoord/server/balancer/balancer_impl.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #39593      +/-   ##
==========================================
- Coverage   80.11%   80.09%   -0.02%     
==========================================
  Files        1465     1465              
  Lines      203083   203135      +52     
==========================================
+ Hits       162700   162708       +8     
- Misses      34576    34617      +41     
- Partials     5807     5810       +3     

Components	Coverage Δ
Client	79.45% <ø> (ø)
Core	69.40% <ø> (-0.02%)	⬇️
Go	81.83% <79.12%> (-0.02%)	⬇️

Files with missing lines	Coverage Δ
...nal/streamingcoord/client/assignment/discoverer.go	91.08% <100.00%> (+1.20%)	⬆️
.../interceptors/segment/manager/partition_manager.go	84.75% <100.00%> (+1.49%)	⬆️
...al/streamingcoord/server/balancer/balancer_impl.go	77.99% <0.00%> (ø)
...er/wal/interceptors/segment/stats/stats_manager.go	94.73% <93.75%> (+10.24%)	⬆️
...al/streamingnode/server/walmanager/manager_impl.go	92.38% <33.33%> (-1.80%)	⬇️
...al/streamingnode/server/walmanager/wal_lifetime.go	79.62% <62.50%> (-1.56%)	⬇️
...server/wal/interceptors/segment/inspector/impls.go	85.85% <50.00%> (-2.32%)	⬇️
...l/interceptors/segment/manager/pchannel_manager.go	66.17% <56.25%> (+0.51%)	⬆️

... and 40 files with indirect coverage changes

[jaime0815]

/lgtm

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• internal/streamingcoord/OWNERS
• internal/streamingnode/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment