Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Add dsl log field for HybridSearch (#39584) #39598

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #39584
The dsl fields are separated in sub request structs and cannot be easily printed before. This PR adds a log helper to print the dsl expressions of HybridSearchRequest.

The dsl fields are separated in sub request structs and cannot be
easiliy printed before. This PR adds a log helper to print the dsl
expressions of HybridSearchRequest.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 26, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (c832793) to head (d6a5a85).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/impl.go 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39598      +/-   ##
==========================================
- Coverage   80.99%   80.99%   -0.01%     
==========================================
  Files        1404     1404              
  Lines      198041   198051      +10     
==========================================
- Hits       160411   160402       -9     
- Misses      31997    32018      +21     
+ Partials     5633     5631       -2     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <ø> (ø)
Go 82.95% <12.50%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.76% <12.50%> (-0.10%) ⬇️

... and 35 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants