fix: [2.5] Use param item formatter to avoid SetConfig to overlay (#39597) #39636
+49
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@congqixia go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39636 +/- ##
==========================================
- Coverage 80.97% 80.95% -0.03%
==========================================
Files 1404 1404
Lines 198043 198043
==========================================
- Hits 160361 160320 -41
- Misses 32034 32061 +27
- Partials 5648 5662 +14
|
…o#39597) Related to milvus-io#39596 When updating the build param configuration, the `Formatter` could be used to do so and completed avoid touching the `overlay` config items --------- Signed-off-by: Congqi Xia <[email protected]>
|
@congqixia go-sdk check failed, comment |
|
rerun go-sdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #39597
Related to #39596
When updating the build param configuration, the
Formattercould be used to do so and completed avoid touching theoverlayconfig items