Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5][GoSDK] sync milvusclient patches for 2.5.1 #40410

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Mar 6, 2025

Cherry pick from master
pr: #40268 #40284 #40328 #40373 #40381


fix: [GoSDK] Pass base64 passwd content instead of raw data (#40268)

Related to #40261

Also add some options for create collection options and refine some
behavior


fix: [GoSDK] Return role without grants (#40284)

Related to #40274

Previousy DescribeRole returns only roles with grants, this PR add
select role action to check role existence.

Also added database properties related option


fix: [GoSDK] Pass only valid data for nullable column (#40328)

Related to #40327


enhance: [GoSDK] Add DescribeReplica API & sync rbac v2 (#40373)

Related to #31293 #37031

This PR:

  • Add DescribeReplica API
  • Add unified RBAC v2 API names(AddPrivilegesToGroup,
    RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2)
  • Mark old ones deprecated

enhance: [GoSDK] support update ts caching policy(#40381)

Related to #39093

This PR add update timestamp check and retry policy according to the
design of the related issue


…o#40268)

Related to milvus-io#40261

Also add some options for create collection options and refine some
behavior

Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#40274

Previousy DescribeRole returns only roles with grants, this PR add
select role action to check role existence.

Also added database properties related option

---------

Signed-off-by: Congqi Xia <[email protected]>
)

Related to milvus-io#31293 milvus-io#37031

This PR:
- Add DescribeReplica API
- Add unified RBAC v2 API names(AddPrivilegesToGroup,
RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2)
- Mark old ones deprecated

Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#39093

This PR add update timestamp check and retry policy according to the
design of the related issue

---------

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Mar 6, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 6, 2025
@dosubot dosubot bot added component/gosdk issues & PRs related to GoSDK package PR | need cherry-pick need cherry pick to other branches labels Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 91.18774% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (1df4631) to head (eff2c21).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
client/milvusclient/write.go 74.28% 6 Missing and 3 partials ⚠️
client/milvusclient/collection_options.go 66.66% 5 Missing ⚠️
client/milvusclient/database_options.go 57.14% 3 Missing ⚠️
client/milvusclient/rbac.go 83.33% 1 Missing and 2 partials ⚠️
client/index/index.go 33.33% 2 Missing ⚠️
client/column/generic_base.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40410      +/-   ##
==========================================
- Coverage   82.65%   80.89%   -1.77%     
==========================================
  Files        1114     1419     +305     
  Lines      171973   200442   +28469     
==========================================
+ Hits       142149   162145   +19996     
- Misses      24145    32613    +8468     
- Partials     5679     5684       +5     
Components Coverage Δ
Client 79.59% <91.18%> (+0.31%) ⬆️
Core 70.17% <ø> (∅)
Go 82.79% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
client/column/array.go 66.32% <100.00%> (+0.34%) ⬆️
client/column/nullable.go 100.00% <100.00%> (ø)
client/entity/field.go 58.62% <100.00%> (+0.15%) ⬆️
client/milvusclient/collection.go 91.73% <100.00%> (+0.06%) ⬆️
client/milvusclient/common.go 79.48% <100.00%> (+15.85%) ⬆️
client/milvusclient/rbac_options.go 100.00% <100.00%> (ø)
client/milvusclient/rbac_v2.go 100.00% <100.00%> (ø)
client/milvusclient/resource_group.go 100.00% <100.00%> (ø)
client/milvusclient/resource_group_option.go 100.00% <100.00%> (ø)
client/milvusclient/write_options.go 65.02% <100.00%> (+0.29%) ⬆️
... and 6 more

... and 332 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThreadDao
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Mar 6, 2025
@sre-ci-robot sre-ci-robot merged commit 629da61 into milvus-io:2.5 Mar 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed component/gosdk issues & PRs related to GoSDK package dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm PR | need cherry-pick need cherry pick to other branches size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants