Skip to content

fix: [2.5] change log info to debug for collection ref #41269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix: [2.5] change log info to debug for collection ref #41269

merged 3 commits into from
Apr 15, 2025

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Apr 14, 2025 •
edited
Loading

master: #41267
issue: #41268

@SpadeA-Tang
done
5a2f4dc 
Signed-off-by: SpadeA <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 14, 2025
@sre-ci-robot sre-ci-robot requested review from congqixia and yah01 April 14, 2025 04:07
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 14, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 14, 2025

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 14, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 14, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

/run-cpu-e2e

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (afc0ca7) to head (8108377).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #41269   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files        1421     1421           
  Lines      203193   203197    +4     
=======================================
+ Hits       164331   164337    +6     
+ Misses      33108    33105    -3     
- Partials     5754     5755    +1
Components Coverage Δ
Client 79.65% <ø> (ø)
Core 70.68% <ø> (ø)
Go 82.75% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/segments/collection.go 92.70% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Apr 14, 2025

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Apr 15, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
trigger CI
8108377 
Signed-off-by: SpadeA <[email protected]>
liliu-z
liliu-z reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liliu-z liliu-z added manual-pass manually set pass before ci-passed labeled ci-passed labels Apr 15, 2025
@sre-ci-robot sre-ci-robot merged commit 699f8a6 into milvus-io:2.5 Apr 15, 2025
19 of 20 checks passed
liliu-z pushed a commit that referenced this pull request Apr 16, 2025
@SpadeA-Tang @liliu-z
fix: [2.5] change log info to debug for collection ref (#41269)
6aeea93 
master: #41267
issue: #41268

---------

Signed-off-by: SpadeA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z left review comments

@czs007 czs007 czs007 approved these changes

@congqixia congqixia Awaiting requested review from congqixia

@yah01 yah01 Awaiting requested review from yah01

Assignees

@czs007 czs007

@liliu-z liliu-z

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpadeA-Tang @sre-ci-robot @czs007 @liliu-z