Skip to content

test: add alter collection checker #41281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

test: add alter collection checker #41281

merged 1 commit into from
Apr 15, 2025
+61 −8

Conversation

zhuwenxing
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 14, 2025
@zhuwenxing zhuwenxing requested a review from Copilot April 14, 2025 11:14
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing labels Apr 14, 2025
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/python_client/chaos/checker.py:1868

  • The property 'collection.ttl.seconds' is configured as an integer (3600) but compared with the string "3600"; ensure type consistency.
if properties["collection.ttl.seconds"] != "3600":

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567, zhuwenxing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6a12304 into milvus-io:master Apr 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@binbinlv binbinlv Awaiting requested review from binbinlv

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor kind/test lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuwenxing @yanliang567 @sre-ci-robot