fix: handle equipped items in inventory actions - #809
Open
tylergibbs1 wants to merge 1 commit into
Open
Conversation
Discarding and chest deposits only searched regular inventory slots, so armor and offhand items were reported missing. Search equipment as a fallback, transfer from the exact slot, and safely unequip items before chest deposits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
findInventoryItemonly searches regular player inventory slots, sodiscard,giveToPlayer, andputInChesttreated armor and offhand items as missing.This change:
Closes #800
testing
node --check src/agent/library/skills.jsdiscardandputInChestfunctions with mocked offhand inventorygit diff --checkI did not run a live Minecraft session or ESLint because this sparse checkout does not have the project dependencies installed.