add Muon Optimizer #1165
Closed
add Muon Optimizer #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
pls add the test script |
Collaborator
Author
done |
SamitHuang
approved these changes
Jul 16, 2025
SamitHuang
reviewed
Jul 16, 2025
| @@ -0,0 +1,236 @@ | |||
| """Modified from https://github.com/MoonshotAI/Moonlight/blob/master/examples/toy_train.py""" | |||
Collaborator
There was a problem hiding this comment.
add copyright statement
Collaborator
Author
There was a problem hiding this comment.
add copyright statement
original script does not contain copyright statement
mindone/trainers/muon.py
Outdated
| X = X / (mint.norm(X) + 1e-7) | ||
| # Perform the NS iterations | ||
| for _ in range(steps): | ||
| A = X @ X.T |
Collaborator
There was a problem hiding this comment.
may try mint.matmul explicitly for better performance
Collaborator
Author
There was a problem hiding this comment.
updated. Yes, change to mint get 15% speed boost
CaitinZhao
approved these changes
Jul 18, 2025
Collaborator
Author
|
merged in #1198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需配合 #1164 保障测试脚本收敛精度
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx