Skip to content

Conversation

Cui-yshoho
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@Cui-yshoho Cui-yshoho requested a review from vigo999 as a code owner September 30, 2025 03:22
Copy link
Contributor

Summary of Changes

Hello @Cui-yshoho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor code hygiene and structural improvements rather than introducing new features or fixing bugs. The changes primarily involve reordering import statements for specific models, adjusting a type hint for clarity or compatibility, and a small docstring formatting correction. These updates contribute to a cleaner and more consistent codebase.

Highlights

  • Import Reordering: The import statements for RTDetr and RTDetrV2 models were reordered in both mindone/transformers/__init__.py and mindone/transformers/models/__init__.py for better organization.
  • Type Hint Adjustment: A type hint for the zero_helper parameter in mindone/transformers/mindspore_adapter/train_onestep_wrapper.py was updated from Optional[ZeroHelper] to Optional["ZeroHelper"], likely to address a forward reference or improve compatibility.
  • Docstring Cleanup: A minor formatting correction was made in mindone/transformers/models/reformer/modeling_reformer.py by removing an extraneous blank line from a docstring.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several small but beneficial changes to improve code quality and maintainability. The changes include reordering imports and module listings to maintain alphabetical order, which enhances readability. A type hint has been corrected to properly handle a forward reference, preventing potential runtime issues. Additionally, a minor whitespace issue in a docstring has been fixed. Overall, these are good housekeeping changes and I have no further suggestions.

@Cui-yshoho Cui-yshoho changed the title test fix ci issue Sep 30, 2025
past_buckets_states (`List[Tuple(ms.Tensor, ms.Tensor)]`, *optional*, returned when `use_cache=True` is passed or when `config.use_cache=True`):
List of `Tuple(ms.Tensor, ms.Tensor` of length `config.n_layers`, with the first element
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is refered to #1339, which has been fixed

@vigo999 vigo999 added this pull request to the merge queue Sep 30, 2025
Merged via the queue into mindspore-lab:master with commit a1f1852 Sep 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants