-
Notifications
You must be signed in to change notification settings - Fork 88
fix ci issue #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci issue #1341
Conversation
Summary of ChangesHello @Cui-yshoho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on minor code hygiene and structural improvements rather than introducing new features or fixing bugs. The changes primarily involve reordering import statements for specific models, adjusting a type hint for clarity or compatibility, and a small docstring formatting correction. These updates contribute to a cleaner and more consistent codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several small but beneficial changes to improve code quality and maintainability. The changes include reordering imports and module listings to maintain alphabetical order, which enhances readability. A type hint has been corrected to properly handle a forward reference, preventing potential runtime issues. Additionally, a minor whitespace issue in a docstring has been fixed. Overall, these are good housekeeping changes and I have no further suggestions.
8bcb903
to
4b9a09d
Compare
past_buckets_states (`List[Tuple(ms.Tensor, ms.Tensor)]`, *optional*, returned when `use_cache=True` is passed or when `config.use_cache=True`): | ||
List of `Tuple(ms.Tensor, ms.Tensor` of length `config.n_layers`, with the first element | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is refered to #1339, which has been fixed
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx