fix(MenuService): update create method to return Menu type and correct parent_id reference

[People-Sea]

Close: #554

Summary by CodeRabbit

• 重构
  • 调整了菜单权限处理逻辑，统一了标识符命名，使描述更清晰。
  • 优化了返回类型定义，提升了代码的类型安全性和整体可维护性。

[coderabbitai]

📝 Walkthrough

Walkthrough

此次变更中，MenuService 类中的 create 方法进行了更新。方法返回类型由 mixed 调整为 Menu，数组中表示父级 ID 的键由 pid 改为 parent_id，同时添加了变量的类型提示以增强代码可读性和安全性。总体逻辑未变，仅对类型和命名进行了优化。

Changes

文件	更改摘要
app/.../MenuService.php	更新 create 方法返回类型 (mixed → Menu)、数组键由 pid 改为 parent_id 且新增类型注释

Sequence Diagram(s)

sequenceDiagram
    participant 客户端 as Client
    participant 服务 as MenuService
    participant 仓库 as Repository
    participant 菜单 as Menu实体

    客户端->>服务: 调用 create(data)
    服务->>仓库: 使用键 parent_id 创建菜单数据
    仓库-->>服务: 返回 Menu 对象
    服务-->>客户端: 返回 Menu 实体

Loading

Suggested labels

bug, size:S

Poem

我是一只快乐的小兔，
在代码森林中轻快跳跃。
返回类型变得明确如月，
键名更新闪耀如星辰。
新改动铺展代码春天，乐在其中！ 🐰

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c2eede and 051d05a.

📒 Files selected for processing (1)

• app/Service/Permission/MenuService.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: Test on PHP8.1 Swoole-master
• GitHub Check: Test on PHP8.1 Swoole-v5.1.5
• GitHub Check: Test on PHP8.1 Swoole-v5.0.3
• GitHub Check: Test on PHP8.2 Swoole-master
• GitHub Check: Test on PHP8.2 Swoole-v5.1.5
• GitHub Check: Test on PHP8.1 Swow-develop
• GitHub Check: Test on PHP8.2 Swoole-v5.0.3
• GitHub Check: Test on PHP8.2 Swow-develop
• GitHub Check: Test on PHP8.3 Swoole-master
• GitHub Check: Test on PHP8.3 Swow-develop
• GitHub Check: Test on PHP8.3 Swoole-v5.1.5
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: build Code coverage report (ubuntu-latest, 8.1, v5.1.3)

🔇 Additional comments (3)

app/Service/Permission/MenuService.php (3)

33-33: 优化返回类型定义为更明确的 Menu 类型

将方法返回类型从 mixed 改为具体的 Menu 类型，这样的修改增强了类型安全性，使代码更加健壮，同时为 IDE 提供了更好的类型提示支持。

---

35-37: 添加了清晰的变量类型提示注释

为 $model 变量添加了 @var Menu 类型提示注释，这种做法提高了代码可读性，有助于开发者更好地理解变量类型，同时与方法返回类型的修改保持一致。

---

42-42: 将键名从 'pid' 更改为 'parent_id'，保持命名一致性

这个修改使参数命名更加规范和一致。注意到在第 74 行的 updateById 方法中已经使用了 'parent_id'，所以这个更改使整个代码库的命名约定更加统一，提高了代码的一致性和可维护性。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or PR title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kanyxmo]

@zds-s 来审下