Skip to content

Update shadowJar includes to ignore useless runtime test configs #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: wguss/unification
Choose a base branch
from
Open

Update shadowJar includes to ignore useless runtime test configs #376

wants to merge 2 commits into from

Conversation

@brandonhoughton
Copy link
Member

@brandonhoughton brandonhoughton commented Aug 18, 2020

No description provided.

@brandonhoughton
Update shadowJar includes to ignore useless runtime test configs
654f482
@brandonhoughton
Revert handler re-scoping
adb14d7 
Update full_action_observation_mixin.py to work properly (needs to be refactored)
Fixes issues with the build-kite fat-jar build.gradle
Working with interactive mode currently!
@pep8speaks
Copy link

pep8speaks commented Aug 19, 2020

Hello @brandonhoughton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:9: E128 continuation line under-indented for visual indent
Line 36:17: E203 whitespace before ':'
Line 36:25: E252 missing whitespace around parameter equals
Line 95:80: E501 line too long (82 > 79 characters)
Line 148:80: E501 line too long (97 > 79 characters)

Line 522:80: E501 line too long (100 > 79 characters)
Line 526:80: E501 line too long (82 > 79 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandonhoughton @pep8speaks