Tests for pkg/utils (#3155)

Signed-off-by: Daniel Valdivia <[email protected]>
minio · Dec 11, 2023 · 9db5d1e · 9db5d1e
1 parent 4cadaf7
commit 9db5d1e
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 18 deletions.
diff --git a/pkg/logger/message/audit/entry.go b/pkg/logger/message/audit/entry.go
@@ -22,6 +22,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/google/uuid"
+
 	"github.com/golang-jwt/jwt/v4"
 
 	"github.com/minio/console/pkg/utils"
@@ -100,7 +102,7 @@ func ToEntry(w http.ResponseWriter, r *http.Request, reqClaims map[string]interf
 	var requestID interface{}
 	requestID = r.Context().Value(utils.ContextRequestID)
 	if requestID == nil {
-		requestID, _ = utils.NewUUID()
+		requestID = uuid.NewString()
 	}
 	entry.RequestID = requestID.(string)
 

diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go
@@ -19,19 +19,8 @@ package utils
 import (
 	"context"
 	"encoding/base64"
-
-	"github.com/google/uuid"
 )
 
-// NewUUID - get a random UUID.
-func NewUUID() (string, error) {
-	u, err := uuid.NewRandom()
-	if err != nil {
-		return "", err
-	}
-	return u.String(), nil
-}
-
 // DecodeBase64 : decoded base64 input into utf-8 text
 func DecodeBase64(s string) (string, error) {
 	decodedInput, err := base64.StdEncoding.DecodeString(s)

diff --git a/pkg/utils/utils_test.go b/pkg/utils/utils_test.go
@@ -16,7 +16,10 @@
 
 package utils
 
-import "testing"
+import (
+	"context"
+	"testing"
+)
 
 func TestDecodeInput(t *testing.T) {
 	type args struct {
@@ -90,3 +93,36 @@ func TestDecodeInput(t *testing.T) {
 		})
 	}
 }
+
+func TestClientIPFromContext(t *testing.T) {
+	type args struct {
+		ctx context.Context
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{
+		{
+			name: "working return",
+			args: args{
+				ctx: context.Background(),
+			},
+			want: "127.0.0.1",
+		},
+		{
+			name: "context contains ip",
+			args: args{
+				ctx: context.WithValue(context.Background(), ContextClientIP, "10.0.0.1"),
+			},
+			want: "10.0.0.1",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := ClientIPFromContext(tt.args.ctx); got != tt.want {
+				t.Errorf("ClientIPFromContext() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
diff --git a/restapi/configure_console.go b/restapi/configure_console.go
@@ -35,6 +35,8 @@ import (
 	"sync"
 	"time"
 
+	"github.com/google/uuid"
+
 	"github.com/minio/console/pkg/logger"
 	"github.com/minio/console/pkg/utils"
 	"github.com/minio/minio-go/v7/pkg/credentials"
@@ -192,11 +194,7 @@ func setupMiddlewares(handler http.Handler) http.Handler {
 
 func ContextMiddleware(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		requestID, err := utils.NewUUID()
-		if err != nil && err != auth.ErrNoAuthToken {
-			http.Error(w, err.Error(), http.StatusInternalServerError)
-			return
-		}
+		requestID := uuid.NewString()
 		ctx := context.WithValue(r.Context(), utils.ContextRequestID, requestID)
 		ctx = context.WithValue(ctx, utils.ContextRequestUserAgent, r.UserAgent())
 		ctx = context.WithValue(ctx, utils.ContextRequestHost, r.Host)