To include pkg tests in the coverage #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
testing-coverage-1
branch
2 times, most recently
from
4e4720c to
38c7604
Compare
cniackz
force-pushed
the
testing-coverage-1
branch
from
38c7604 to
4dbaed5
Compare
cniackz
changed the title
dvaldivia
approved these changes
Dec 26, 2023
This was referenced Dec 26, 2023
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Execute and include pkg tests in the coverage
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Execute and include pkg tests in the coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To execute and include the
pkgtests in the coverage as they are currently excluded from our CI/CD Pipeline.Problem:
Currently, when we execute the tests, they are not included:
Root Cause:
This is because the tests are distributed in the sub-folders, hence we need to use
go test ./...to include the tests in the sub-folders as stated in https://stackoverflow.com/questions/19200235/golang-tests-in-sub-directoryAdditional information:
This change is unrelated to the failure observed in
func TestToEntry(t *testing.T) {and that test was introduced long time ago but we never debugged when started to fail. So for this PR, I am going to suggest its temporal removal and in a separate PR when can degub that test further.