-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow console to recognize s3.DeleteObject* #3497
base: master
Are you sure you want to change the base?
Allow console to recognize s3.DeleteObject* #3497
Conversation
@allanrogerr could you please take a look at the failing test? Thanks! |
It has been failing for > 1 month: Not sure what broke earlier @bayasdev |
I will take a look in a subsequent PR. |
@allanrogerr , Please note , the action needs to be checked for :
|
@prakashsvmx regarding your comment, is this PR not complete? were you able to test it? |
@cesnietor , @allanrogerr yes., e.g: The delete option is not present for the tag even though it is allowed (with mc and same policy the tag can be removed) {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"s3:PutObject*",
"s3:DeleteObject*",
"s3:ListAllMyBuckets",
"s3:ListBucket",
"s3:ListBucketVersions",
"s3:PutObjectTagging",
"s3:GetBucketVersioning",
"s3:GetObject*",
"s3:GetObjectTagging"
],
"Resource": [
"arn:aws:s3:::test-bucket",
"arn:aws:s3:::test-bucket/*"
]
}
]
} |
Working on it |
Issue
Console searches for the precise policy
s3:DeleteObject
when allowing a delete of an object or prefix. If a user specifies the usage of the supersets3:DeleteObject*
, console will disallow delete, even though this is allowed by api.This PR allows a user attached to a policy defined with
s3:DeleteObject*
to be able to delete this object through the Console UI.How to test
1.- Define infrastructure
2.- Create a user with restricted privileges using
s3:DeleteObject*
e.g.
3.- Login to the UI as
test-user
and successfully delete the uploaded filefixes #3217