Added structs for replication diag #330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
force-pushed
the
replication-diag
branch
3 times, most recently
from
36857be to
9fcf548
Compare
harshavardhana
changed the title
shtripat
force-pushed
the
replication-diag
branch
2 times, most recently
from
97c3c3e to
1f02702
Compare
replication.go
Outdated
| ActiveWorkers WorkerStat `json:"active_workers,omitempty"` | ||
| Queued InQueueMetric `json:"queued,omitempty"` | ||
| ReplicaCount int64 `json:"replica_count,omitempty"` | ||
| ReplicaSize int64 `json:"replica_size,omitempty"` |
There was a problem hiding this comment.
What do ReplicaCount and ReplicaSize represent?
There was a problem hiding this comment.
ReplicaCount = no of objects replicated
ReplicaSize = no of bytes replicated
IIUC
| Edge bool `json:"edge,omitempty"` | ||
| ILMEnabled bool `json:"ilm_enabled,omitempty"` | ||
| EncryptionEnabled bool `json:"encryption_enabled,omitempty"` | ||
| ILMExpiryReplication bool `json:"ilm_expiry_replication,omitempty"` |
There was a problem hiding this comment.
Shouldn't lines 46-54 be captured per node, perhaps in MinIONode below, the intention being, to flag any mismatch across nodes in the subsequent reporting step?
There was a problem hiding this comment.
My thought was that across sites if they mismatch, that itself is issue
shtripat
force-pushed
the
replication-diag
branch
from
1f02702 to
be7b6cc
Compare
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
replication-diag
branch
from
be7b6cc to
1129345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.