-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support --custom-header flags #5127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use globals. Although it may be tempting for a "run-once" per process tool as mc
to use globals it makes unit-testing harder (and it's considered bad practice anyway).
1e9ee66
to
a3fd0b5
Compare
7b7d191
to
c8eed15
Compare
This is worse now. @ramondeklein was this what you meant? |
@klauspost No. There should be a better way to provide CLI parameters. A 200 file change PR is not acceptable. I've not the time to work on this, but it's hard to believe we need to change 200 files to send a custom header... |
7a92ee9
to
4350d40
Compare
212b74d
to
b86dbf8
Compare
add custom-header flags
3d604ed
to
1e5d857
Compare
Co-authored-by: Ramon de Klein <[email protected]>
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
support header flags
Allows user use
--custom-header="HeaderA:ValueA" --custom-header="HeaderB:ValueB"
to sent custom header to S3.Motivation and Context
How to test this PR?
mc ls minio --custom-header "MyHeaderA:Value" --custom-header "MyHeaderB:Value" --debug
Types of changes
Checklist:
commit-id
orPR #
here)