Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping:support ping a specified node and remove duplicate port printing #5132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Feb 11, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The output of the ping command repeatedly displays port information.
image
You cannot ping a specific node. You can only view information about all nodes.
image

Motivation and Context

When there are a large number of node, it is difficult to view the ping result of an node.

How to test this PR?

mc ping myminio --node minio-1.minio-headless.kube-system.svc.cluster.local:8989
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze dormanze changed the title ping:support ping a specified node ping:support ping a specified node and remove duplicate port printing Feb 11, 2025
@dormanze
Copy link
Contributor Author

After I update your commit, my testcase fails to be executed. Can you help me fix the problem?@harshavardhana I'm very grateful.

@klauspost
Copy link
Contributor

Sent fix in #5134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants