Add CRC64NVME checksum type. #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds `CRC32-FO` and `CRC32C-FO` for full object checksums. ``` λ mc cp -checksum=crc64nvme mc.exe myminio/testbucket ...com\minio\mc\mc.exe: 41.95 MiB / 41.95 MiB λ mc stat myminio/testbucket/mc.exe Name : mc.exe Date : 2025-02-14 13:59:05 CET Size : 42 MiB ETag : 7f130846cec6e6ece750565b1f3d9518-3 VersionID : f4daeb78-9eaf-4da9-b9ca-d8b65fbc69e3 Type : file Checksum : CRC64NVME:TOfg0RHhpZk= Metadata : Content-Type: application/x-msdownload λ mc cp -checksum=crc32-fo mc.exe myminio/testbucket ...com\minio\mc\mc.exe: 41.95 MiB / 41.95 MiB λ mc stat myminio/testbucket/mc.exe Name : mc.exe Date : 2025-02-14 13:58:52 CET Size : 42 MiB ETag : 7f130846cec6e6ece750565b1f3d9518-3 VersionID : 1ec587dd-9127-42ee-ad82-58b48f9676d5 Type : file Checksum : CRC32:3Dt3fQ== Metadata : Content-Type: application/x-msdownload λ _ ```
marktheunissen
approved these changes
Feb 14, 2025
harshavardhana
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also adds
CRC32-FOandCRC32C-FOfor full object checksums.Upgrades minio-go to version with assembly crc64nvme.How to test this PR?
Run latest version minio. Run above examples.
Types of changes