Skip to content

mirror:not overwrit target object when mirror watch #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Apr 23, 2025

fix #5192

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Motivation and Context

make sure mirror command overwrit same when the watch is used and when the watch command is not used.

How to test this PR?

mc mb local/bucket
mc mb peer/bucket
echo "1" > txt
mc cp txt peer/bucket
mc mirror -w local/bucket peer/bucket
echo "2" > txt
mc cp txt local/bucket
mc cat peer/bucket/txt
mc mb local/bucket
mc mb peer/bucket
echo "3" > txt
mc cp txt peer/bucket
mc mirror -w --overwrite local/bucket peer/bucket
echo "4" > txt
mc cp txt local/bucket
mc cat peer/bucket/txt

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

not overwrit target object when mirror watch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mc mirror will overwrite the same key in target minio bucket
1 participant