Skip to content

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Jul 7, 2025

Fix #174

This will allow you to specify hmac and sha2 dependencies, while disabling default features to enable rustls feature

@HJLebbink HJLebbink requested a review from Copilot July 7, 2025 15:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors feature flags in Cargo.toml to support using rustls alongside sha2 and hmac by grouping crypto deps into a single feature.

  • Introduce default-crypto to bundle sha2 and hmac
  • Update default features to include default-crypto instead of listing crypto deps individually
  • Keep TLS options unchanged
Comments suppressed due to low confidence (2)

Cargo.toml:23

  • Consider updating the README or other documentation to describe the new default-crypto feature, its purpose, and how to enable it in combination with rustls.
default-crypto = ["dep:sha2", "dep:hmac"]

Cargo.toml:19

  • Add a CI or integration test that builds the crate with --no-default-features --features rustls-tls,default-crypto to ensure compatibility and prevent regressions.
default = ["default-tls", "default-crypto"]

@HJLebbink HJLebbink added the enhancement Used in release doc generation label Aug 12, 2025
@HJLebbink HJLebbink self-requested a review August 12, 2025 17:54
Copy link
Member

@HJLebbink HJLebbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HJLebbink HJLebbink merged commit e73fa10 into minio:master Aug 12, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Used in release doc generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use this library with rustls ?
2 participants