-
Notifications
You must be signed in to change notification settings - Fork 75
Refactor/cleanup errors #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2267cd6 to
d9516d6
Compare
d9516d6 to
bd7ed58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the error handling system to create a hierarchical error structure, replacing a single flat Error enum with a higher-level Error enum and four specialized error types: ValidationErr, S3ServerError, ReqwestError, and IoError.
- Error hierarchy restructuring: Replaced monolithic Error enum with specialized error types for better error categorization and handling
- Header constant consolidation: Centralized HTTP header constants in a dedicated module to improve consistency and maintainability
- Testing improvements: Enhanced test structure with helper functions and additional test cases for edge cases like whitespace handling
Reviewed Changes
Copilot reviewed 131 out of 131 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/s3/error.rs | Complete restructure of error types into hierarchical system |
| src/s3/header_constants.rs | New module containing all HTTP header constants |
| src/s3/minio_error_response.rs | New module for S3-specific error responses and error codes |
| tests/* | Multiple test files refactored with helper functions and additional test cases |
| src/s3/utils.rs | Updated utility functions to use new error types and URL encoding |
Comments suppressed due to low confidence (1)
src/s3/utils.rs:27
- This type alias is defined but never used in the diff. Consider removing it if it's not needed.
use md5::compute as md5compute;
62764d7 to
b70df3e
Compare
|
This is great! please fix conflicts. |
41a16e1 to
564bc9a
Compare
84a966e to
1243a19
Compare
…at are not compatible with 1.87.0
f3a50da to
6d48b00
Compare
6d48b00 to
a894782
Compare
|
@donatello fixed merge issues. PTAL |
refactored errors to create a higher level Error and four lower level errors