grid: Remove allocs #18367
Merged
grid: Remove allocs #18367
+142
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
klauspost
force-pushed
the
grid-remove-allocs
branch
from
7731e97 to
68cec68
Compare
harshavardhana
approved these changes
Nov 1, 2023
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Nov 16, 2023
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(against next)
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks.
Websocket library updated to include gobwas/ws#189
How to test this PR?
Run included benchmark
Types of changes