Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the search filter panel on scroll when users are browsing. #745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wilson1000
Copy link
Contributor

No description provided.

@EarthlingDavey
Copy link
Contributor

Hey @wilson1000 , I just spotted this PR even though you haven't requested a review.

I've done a similar thing on a different website, it might be worth checking to see if the css property position: sticky would be suitable here. If it's suitable it would mean you don't really need the custom js.

With a quick test in browser developer tools, adding the below css seems like it might work.

@media only screen and (min-width: 740px) {
    .l-main .l-secondary {
        ...
        position: sticky;
        top: 20px;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants